commit f917cd0e42642aefc8924379f4dacacb6563bc24
author Marcus Meissner <marcus@jet.franken.de> Sat Jul 07 11:52:24 2012 +0200
committer Alexandre Julliard <julliard@winehq.org> Mon Jul 09 10:11:56 2012 -0400
tree 35987f08996c854e75928e614b1c18502a65b6b7
parent 0ef705fb69903d68c53a77700e167f68f9b8c55c

user.exe: Avoid truncating strcmp result (Coverity).

dlls/user.exe16/user.c

diff --git a/dlls/user.exe16/user.c b/dlls/user.exe16/user.c
index 705620b..7f184a2 100644
--- a/dlls/user.exe16/user.c
+++ b/dlls/user.exe16/user.c
@@ -2557,7 +2557,14 @@
  */
 INT16 WINAPI lstrcmp16( LPCSTR str1, LPCSTR str2 )
 {
-    return strcmp( str1, str2 );
+    int ret;
+    /* Looks too complicated, but in optimized strcpy we might get
+    * a 32bit wide difference and would truncate it to 16 bit, so
+     * erroneously returning equality. */
+    ret = strcmp( str1, str2 );
+    if (ret < 0) return -1;
+    if (ret > 0) return  1;
+    return 0;
 }