commit e979832dda71deeea092c31046f543fbeec13c5c
author Alexandre Julliard <julliard@winehq.org> Wed Feb 08 15:06:42 2006 +0100
committer Alexandre Julliard <julliard@winehq.org> Wed Feb 08 15:06:42 2006 +0100
tree 7ddc869f5856489658946ffed0bf6aa6444fef44
parent d815b507561c86af31d3ea8d94e37423319de675

server: Fixed handling of inotify record length.

server/change.c

diff --git a/server/change.c b/server/change.c
index c35a82c..e32997e 100644
--- a/server/change.c
+++ b/server/change.c
@@ -416,7 +416,8 @@
 
     if (dir->want_data)
     {
-        record = malloc( sizeof (*record) + ie->len - 1 ) ;
+        size_t len = strlen(ie->name);
+        record = malloc( offsetof(struct change_record, name[len]) );
         if (!record)
             return;
 
@@ -426,8 +427,8 @@
             record->action = FILE_ACTION_REMOVED;
         else
             record->action = FILE_ACTION_MODIFIED;
-        memcpy( record->name, ie->name, ie->len );
-        record->len = strlen( ie->name );
+        memcpy( record->name, ie->name, len );
+        record->len = len;
 
         list_add_tail( &dir->change_records, &record->entry );
     }
@@ -456,13 +457,14 @@
         return;
     }
 
-    for( ofs = 0; ofs < r; )
+    for( ofs = 0; ofs < r - offsetof(struct inotify_event, name); )
     {
         ie = (struct inotify_event*) &buffer[ofs];
         if (!ie->len)
             break;
+        ofs += offsetof( struct inotify_event, name[ie->len] );
+        if (ofs > r) break;
         inotify_do_change_notify( dir, ie );
-        ofs += (sizeof (*ie) + ie->len - 1);
     }
 }