commit e4ab07e0fee56ddf48063e62a9046b7efea6150c
author Louis Philippe Gagnon <louisphilippe@macadamian.com> Mon Oct 23 00:36:06 2000 +0000
committer Alexandre Julliard <julliard@winehq.org> Mon Oct 23 00:36:06 2000 +0000
tree 64e0db05046dea8fc5bfa58da6fd80c63bb41824
parent 409eb44eb00e0fc1a0ebc7ed1a5eed6e59841d88

- Calculate changes in the client area relative to the window
  instead of its parent when using SWP_EX_PAINTSELF.
- With SWP_EX_PAINTSELF, copy only if client area changed, since a
  window can't move relative to itself.
- In SWP_DoNCCalcSize, when determining if the client area
  changed, use values relative to the window itself, not its parent.

windows/winpos.c

diff --git a/windows/winpos.c b/windows/winpos.c
index 486c3d0..07aae45 100644
--- a/windows/winpos.c
+++ b/windows/winpos.c
@@ -2212,9 +2212,6 @@
  * visible and update regions are in window coordinates
  * client and window rectangles are in parent client coordinates
  *
- * FIXME: SWP_EX_PAINTSELF in uFlags works only if both old and new
- *	  window rects have the same origin.
- *
  * Returns: uFlags and a dirty region in *pVisRgn.
  */
 static UINT SWP_CopyValidBits( WND* Wnd, HRGN* pVisRgn,
@@ -2289,8 +2286,20 @@
           ((lpOldClientRect->left - lpOldWndRect->left) !=
            (Wnd->rectClient.left - Wnd->rectWindow.left)) )
      {
-	dx = Wnd->rectClient.left - lpOldClientRect->left;
-	dy = Wnd->rectClient.top - lpOldClientRect->top;
+         if(uFlags & SWP_EX_PAINTSELF)
+         {
+             /* movement relative to the window itself */
+             dx = (Wnd->rectClient.left - Wnd->rectWindow.left) -
+                 (lpOldClientRect->left - lpOldWndRect->left) ;
+             dy = (Wnd->rectClient.top - Wnd->rectWindow.top) -
+                 (lpOldClientRect->top - lpOldWndRect->top) ;
+         }
+         else
+         {
+             /* movement relative to the parent's client area */
+             dx = Wnd->rectClient.left - lpOldClientRect->left;
+             dy = Wnd->rectClient.top - lpOldClientRect->top;
+         }
 
 	/* restrict valid bits to the common client rect */
 
@@ -2308,10 +2317,21 @@
      }
      else
      {
-	dx = Wnd->rectWindow.left - lpOldWndRect->left;
-	dy = Wnd->rectWindow.top -  lpOldWndRect->top;
-	if( !(uFlags & SWP_EX_PAINTSELF) )
-	    OffsetRgn( hrgnValid, Wnd->rectWindow.left, Wnd->rectWindow.top );
+         if(uFlags & SWP_EX_PAINTSELF) {
+             /* 
+              * with SWP_EX_PAINTSELF, the window repaints itself. Since a window can't move 
+              * relative to itself, only the client area can change.
+              * if the client rect didn't change, there's nothing to do.
+              */
+             dx = 0;
+             dy = 0;
+         }
+         else
+         {
+             dx = Wnd->rectWindow.left - lpOldWndRect->left;
+             dy = Wnd->rectWindow.top -  lpOldWndRect->top;
+             OffsetRgn( hrgnValid, Wnd->rectWindow.left, Wnd->rectWindow.top );
+         }
 	r = *lpOldWndRect;
      }
 
@@ -2513,9 +2533,14 @@
 
          /* FIXME: WVR_ALIGNxxx */
 
-         if( pNewClientRect->left != wndPtr->rectClient.left ||
-             pNewClientRect->top != wndPtr->rectClient.top )
+         /* check if client area moved relative to the window */
+         if ( ( (wndPtr->rectClient.left - pNewClientRect->left) != 
+                (wndPtr->rectWindow.left - pNewWindowRect->left) ) ||
+              ( (wndPtr->rectClient.top - pNewClientRect->top) != 
+                (wndPtr->rectWindow.top - pNewWindowRect->top) ) )
+         {   
              pWinpos->flags &= ~SWP_NOCLIENTMOVE;
+         }
 
          if( (pNewClientRect->right - pNewClientRect->left !=
               wndPtr->rectClient.right - wndPtr->rectClient.left) ||