commit e1afe33ac7a1d4fef7728d67cd971dc41a6c2093
author Juan Lang <juan_lang@yahoo.com> Tue May 23 21:56:00 2006 -0700
committer Alexandre Julliard <julliard@winehq.org> Wed May 24 10:24:54 2006 +0200
tree 45befd8f4cdc722c31123213c88214d9e3430eda
parent 29a8dd47a80e6cfa943770b060379796e86ea172

crypt32: Test and fix a couple CertAddCertificateContextToStore corner cases.

dlls/crypt32/store.c

diff --git a/dlls/crypt32/store.c b/dlls/crypt32/store.c
index c150229..160cfdd 100644
--- a/dlls/crypt32/store.c
+++ b/dlls/crypt32/store.c
@@ -2044,6 +2044,12 @@
     TRACE("(%p, %p, %08lx, %p)\n", hCertStore, pCertContext,
      dwAddDisposition, ppStoreContext);
 
+    /* Weird case to pass a test */
+    if (dwAddDisposition == 0)
+    {
+        SetLastError(STATUS_ACCESS_VIOLATION);
+        return FALSE;
+    }
     if (dwAddDisposition != CERT_STORE_ADD_ALWAYS)
     {
         BYTE hashToAdd[20];
@@ -2095,8 +2101,11 @@
 
     if (toAdd)
     {
-        ret = store->certs.addContext(store, (void *)toAdd, (void *)existing,
-         (const void **)ppStoreContext);
+        if (store)
+            ret = store->certs.addContext(store, (void *)toAdd,
+             (void *)existing, (const void **)ppStoreContext);
+        else if (ppStoreContext)
+            *ppStoreContext = CertDuplicateCertificateContext(toAdd);
         CertFreeCertificateContext(toAdd);
     }
     CertFreeCertificateContext(existing);

dlls/crypt32/tests/store.c

diff --git a/dlls/crypt32/tests/store.c b/dlls/crypt32/tests/store.c
index a3624f1..3d487ac 100644
--- a/dlls/crypt32/tests/store.c
+++ b/dlls/crypt32/tests/store.c
@@ -152,6 +152,28 @@
         PCCERT_CONTEXT context;
         BOOL ret;
 
+        /* Weird--bad add disposition leads to an access violation in Windows.
+         */
+        ret = CertAddEncodedCertificateToStore(0, X509_ASN_ENCODING, bigCert,
+         sizeof(bigCert), 0, NULL);
+        ok(!ret && GetLastError() == STATUS_ACCESS_VIOLATION,
+         "Expected STATUS_ACCESS_VIOLATION, got %08lx\n", GetLastError());
+        ret = CertAddEncodedCertificateToStore(store, X509_ASN_ENCODING,
+         bigCert, sizeof(bigCert), 0, NULL);
+        ok(!ret && GetLastError() == STATUS_ACCESS_VIOLATION,
+         "Expected STATUS_ACCESS_VIOLATION, got %08lx\n", GetLastError());
+
+        /* Weird--can add a cert to the NULL store (does this have special
+         * meaning?)
+         */
+        context = NULL;
+        ret = CertAddEncodedCertificateToStore(0, X509_ASN_ENCODING, bigCert,
+         sizeof(bigCert), CERT_STORE_ADD_ALWAYS, &context);
+        ok(ret, "CertAddEncodedCertificateToStore failed: %08lx\n",
+         GetLastError());
+        if (context)
+            CertFreeCertificateContext(context);
+
         ret = CertAddEncodedCertificateToStore(store, X509_ASN_ENCODING,
          bigCert, sizeof(bigCert), CERT_STORE_ADD_ALWAYS, NULL);
         ok(ret, "CertAddEncodedCertificateToStore failed: %08lx\n",