commit e1a836933f3ca25d8033cedb67a04df845d69750
author Juan Lang <juan.lang@gmail.com> Thu Nov 15 11:06:07 2007 -0800
committer Alexandre Julliard <julliard@winehq.org> Fri Nov 16 12:36:01 2007 +0100
tree b2dd139416d9ec6561a5746c1d1d5a6b2f54e0f8
parent 9ec6e33e32fa9f4c0353c1f59c01c5f2ff792d97

iphlpapi: Don't allocate gobs of memory if the IP address table is empty.

dlls/iphlpapi/ifenum.c

diff --git a/dlls/iphlpapi/ifenum.c b/dlls/iphlpapi/ifenum.c
index 1ae70df..0a74ef6 100644
--- a/dlls/iphlpapi/ifenum.c
+++ b/dlls/iphlpapi/ifenum.c
@@ -746,8 +746,11 @@
     ret = enumIPAddresses(&numAddresses, &ifc);
     if (!ret)
     {
-      *ppIpAddrTable = HeapAlloc(heap, flags, sizeof(MIB_IPADDRTABLE) +
-       (numAddresses - 1) * sizeof(MIB_IPADDRROW));
+      DWORD size = sizeof(MIB_IPADDRTABLE);
+
+      if (numAddresses > 1)
+        size += (numAddresses - 1) * sizeof(MIB_IPADDRROW);
+      *ppIpAddrTable = HeapAlloc(heap, flags, size);
       if (*ppIpAddrTable) {
         DWORD i = 0, bcast;
         caddr_t ifPtr;

dlls/iphlpapi/iphlpapi_main.c

diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c
index b65276c..0de8858 100644
--- a/dlls/iphlpapi/iphlpapi_main.c
+++ b/dlls/iphlpapi/iphlpapi_main.c
@@ -1172,17 +1172,17 @@
     ret = getIPAddrTable(&table, GetProcessHeap(), 0);
     if (ret == NO_ERROR)
     {
-      ULONG size = sizeof(MIB_IPADDRTABLE) + (table->dwNumEntries - 1) *
-       sizeof(MIB_IPADDRROW);
+      ULONG size = sizeof(MIB_IPADDRTABLE);
 
+      if (table->dwNumEntries > 1)
+        size += (table->dwNumEntries - 1) * sizeof(MIB_IPADDRROW);
       if (!pIpAddrTable || *pdwSize < size) {
         *pdwSize = size;
         ret = ERROR_INSUFFICIENT_BUFFER;
       }
       else {
         *pdwSize = size;
-        memcpy(pIpAddrTable, table, sizeof(MIB_IPADDRTABLE) +
-         (table->dwNumEntries - 1) * sizeof(MIB_IPADDRROW));
+        memcpy(pIpAddrTable, table, size);
         if (bOrder)
           qsort(pIpAddrTable->table, pIpAddrTable->dwNumEntries,
            sizeof(MIB_IPADDRROW), IpAddrTableSorter);