commit d92c976803647e4ae75ac9ca4fb7d0e5ad9bacfc
author Francois Gouget <fgouget@codeweavers.com> Thu Nov 20 20:41:04 2008 +0100
committer Alexandre Julliard <julliard@winehq.org> Fri Nov 21 10:00:13 2008 +0100
tree 290bf9a94fcf166fa45a0fbe5b3aee0c2821c526
parent 9d4ab487504ee92bfed0bb05da63fda31f1dc812

regedit: Fix a buffer allocation in export_registry_key().

This fixes a major buffer overflow bug in 'regedit /E'.

programs/regedit/regproc.c

diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c
index c070ab0..6d04a44 100644
--- a/programs/regedit/regproc.c
+++ b/programs/regedit/regproc.c
@@ -1239,7 +1239,7 @@
     val_name_buf = HeapAlloc(GetProcessHeap(), 0,
                              val_name_size * sizeof(*val_name_buf));
     val_buf = HeapAlloc(GetProcessHeap(), 0, val_size);
-    line_buf = HeapAlloc(GetProcessHeap(), 0, line_buf_size);
+    line_buf = HeapAlloc(GetProcessHeap(), 0, line_buf_size * sizeof(*line_buf));
     CHECK_ENOUGH_MEMORY(reg_key_name_buf && val_name_buf && val_buf && line_buf);
 
     if (reg_key_name && reg_key_name[0]) {