commit c867f3324ec6fd1330c8b3228bc5db79f0b4833c
author Piotr Caban <piotr@codeweavers.com> Thu Oct 06 20:13:38 2011 +0200
committer Alexandre Julliard <julliard@winehq.org> Thu Oct 06 16:46:40 2011 -0500
tree 956d2a6ab9053df22ef36497b0e8584927e5ab7c
parent 190c67c70e0cd3700c04d9c2c42f1389bbd2e691

msvcrt: Free fd entries with incorrect HANDLE value.

dlls/msvcrt/file.c

diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c
index ecbec34..90e0d80 100644
--- a/dlls/msvcrt/file.c
+++ b/dlls/msvcrt/file.c
@@ -797,18 +797,15 @@
   LOCK_FILES();
   hand = msvcrt_fdtoh(fd);
   TRACE(":fd (%d) handle (%p)\n",fd,hand);
-  if (hand == INVALID_HANDLE_VALUE)
+  if (!msvcrt_is_valid_fd(fd)) {
     ret = -1;
-  else if (!CloseHandle(hand))
-  {
-    WARN(":failed-last error (%d)\n",GetLastError());
-    msvcrt_set_errno(GetLastError());
-    ret = -1;
-  }
-  else
-  {
+  } else {
     msvcrt_free_fd(fd);
-    ret = 0;
+    ret = CloseHandle(hand) ? 0 : -1;
+    if (ret) {
+      WARN(":failed-last error (%d)\n",GetLastError());
+      msvcrt_set_errno(GetLastError());
+    }
   }
   UNLOCK_FILES();
   TRACE(":ok\n");