commit c577c27e2b8ca9cd02543655c1d50a6dae2019f6
author Lionel Ulmer <lionel.ulmer@free.fr> Tue May 20 04:21:46 2003 +0000
committer Alexandre Julliard <julliard@winehq.org> Tue May 20 04:21:46 2003 +0000
tree 58d05e32124d022c7f509e0da9868c07fa0ab342
parent 9bf3ac619e37941e6c973005aecda867c8de333f

No need to flush the surface back if last lock was a RO lock.

dlls/ddraw/d3ddevice/mesa.c

diff --git a/dlls/ddraw/d3ddevice/mesa.c b/dlls/ddraw/d3ddevice/mesa.c
index bb6fec6..689d287 100644
--- a/dlls/ddraw/d3ddevice/mesa.c
+++ b/dlls/ddraw/d3ddevice/mesa.c
@@ -112,7 +112,7 @@
 
     TRACE("(%p, %ld)\n", gl_d3d_dev->display,(Drawable)drawable);
     ENTER_GL();
-    if (gl_d3d_dev->state == SURFACE_MEMORY) {
+    if (gl_d3d_dev->state == SURFACE_MEMORY_DIRTY) {
         d3d_dev->flush_to_framebuffer(d3d_dev, NULL);
     }
     gl_d3d_dev->state = SURFACE_GL;
@@ -1127,7 +1127,7 @@
     int num_active_stages = 0;
 
     ENTER_GL();
-    if (glThis->state == SURFACE_MEMORY) {
+    if (glThis->state == SURFACE_MEMORY_DIRTY) {
         This->flush_to_framebuffer(This, NULL);
     }
     LEAVE_GL();
@@ -2431,6 +2431,7 @@
 			       D3DVALUE dvZ,
 			       DWORD dwStencil)
 {
+    IDirect3DDeviceGLImpl *glThis = (IDirect3DDeviceGLImpl *) This;
     GLboolean ztest;
     GLfloat old_z_clear_value;
     GLbitfield bitfield = 0;
@@ -2462,6 +2463,13 @@
     
     /* Clears the screen */
     ENTER_GL();
+
+    if (glThis->state == SURFACE_MEMORY_DIRTY) {
+        /* TODO: optimize here the case where Clear changes all the screen... */
+        This->flush_to_framebuffer(This, NULL);
+    }
+    glThis->state = SURFACE_GL;
+
     if (dwFlags & D3DCLEAR_ZBUFFER) {
 	bitfield |= GL_DEPTH_BUFFER_BIT;
         glGetBooleanv(GL_DEPTH_WRITEMASK, &ztest);
@@ -2740,8 +2748,8 @@
     /* Try to acquire the device critical section */
     EnterCriticalSection(&(d3d_dev->crit));
     
-    if (((is_front == TRUE)  && (gl_d3d_dev->front_state != SURFACE_MEMORY)) ||
-	((is_front == FALSE) && (gl_d3d_dev->state       != SURFACE_MEMORY))) {
+    if (((is_front == TRUE)  && (gl_d3d_dev->front_state == SURFACE_GL)) ||
+	((is_front == FALSE) && (gl_d3d_dev->state       == SURFACE_GL))) {
         /* If the surface is already in memory, no need to do anything here... */
         GLenum buffer_type;
 	GLenum buffer_color;
@@ -2991,6 +2999,7 @@
 {
     BOOLEAN is_front;
     IDirect3DDeviceImpl *d3d_dev = This->d3ddevice;
+    IDirect3DDeviceGLImpl* gl_d3d_dev = (IDirect3DDeviceGLImpl*) d3d_dev;
   
     if ((This->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER|DDSCAPS_PRIMARYSURFACE)) != 0) {
         is_front = TRUE;
@@ -3001,15 +3010,18 @@
 	return;
     }
     /* First, check if we need to do anything. For the backbuffer, flushing is done at the next 3D activity. */
-    if (((This->lastlocktype & DDLOCK_READONLY) == 0) &&
-	(is_front == TRUE)) {
-        GLenum prev_draw;
-	ENTER_GL();
-	glGetIntegerv(GL_DRAW_BUFFER, &prev_draw);
-	glDrawBuffer(GL_FRONT);
-        d3d_dev->flush_to_framebuffer(d3d_dev, pRect);
-	glDrawBuffer(prev_draw);
-	LEAVE_GL();
+    if ((This->lastlocktype & DDLOCK_READONLY) == 0) {
+        if (is_front == TRUE) {
+	    GLenum prev_draw;
+	    ENTER_GL();
+	    glGetIntegerv(GL_DRAW_BUFFER, &prev_draw);
+	    glDrawBuffer(GL_FRONT);
+	    d3d_dev->flush_to_framebuffer(d3d_dev, pRect);
+	    glDrawBuffer(prev_draw);
+	    LEAVE_GL();
+	} else {
+	    gl_d3d_dev->state = SURFACE_MEMORY_DIRTY;
+	}
     }
 
     /* And 'frees' the device critical section */