commit b897ad1774b71e747a74726ea6c280cbd42633c3
author Alex Villacís Lasso <a_villacis@palosanto.com> Sat Sep 16 12:26:06 2006 -0500
committer Alexandre Julliard <julliard@winehq.org> Thu Sep 21 19:56:59 2006 +0200
tree 645238e1c032b7800ff5293f9e42819fa4cc7fb9
parent 0b4eafada9e1b484c19ea99e64aeb57fea405478

msacm: acmDriverPriority() compares dwPriority against negative values.

This issue was spotted by Andrew Talbot.

dlls/msacm32/driver.c

diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c
index e537bc4..37dc929 100644
--- a/dlls/msacm32/driver.c
+++ b/dlls/msacm32/driver.c
@@ -671,9 +671,9 @@
                 if (padid->fdwSupport & ACMDRIVERDETAILS_SUPPORTF_LOCAL) {
                     return MMSYSERR_NOTSUPPORTED;
                 }
-                if (dwPriority != 1 && dwPriority != -1) {
+                if (dwPriority != 1 && dwPriority != (DWORD)-1) {
                     FIXME("unexpected priority %ld, using sign only\n", dwPriority);
-                    if (dwPriority < 0) dwPriority = -1;
+                    if ((signed)dwPriority < 0) dwPriority = (DWORD)-1;
                     if (dwPriority > 0) dwPriority = 1;
                 }
                 
@@ -681,7 +681,7 @@
                     (padid->pPrevACMDriverID->fdwSupport & ACMDRIVERDETAILS_SUPPORTF_LOCAL))) {
                     /* do nothing - driver is first of list, or first after last
                        local driver */
-                } else if (dwPriority == -1 && padid->pNextACMDriverID == NULL) {
+                } else if (dwPriority == (DWORD)-1 && padid->pNextACMDriverID == NULL) {
                     /* do nothing - driver is last of list */
                 } else {
                     MSACM_RePositionDriver(padid, dwPriority);