commit b599f89abefc01cb474f00b574c2533feb3f8886
author Dylan Smith <dylan.ah.smith@gmail.com> Tue Jun 24 14:09:54 2008 -0400
committer Alexandre Julliard <julliard@winehq.org> Wed Jun 25 10:48:28 2008 +0200
tree e4362774922cc740b72968b816e7309c7a3c9a1e
parent beccf3758692cb48b7ac8bc30265ae36d0e50771

winemine: Increased buffer size for player names.

Player names can be 31 characters long in Windows, so winemine should
now be able to read any of the player names in the registry created from
the minesweeper in the native Windows.

programs/winemine/README

diff --git a/programs/winemine/README b/programs/winemine/README
index e364935..711b5f9 100644
--- a/programs/winemine/README
+++ b/programs/winemine/README
@@ -8,9 +8,6 @@
 Enjoy. I wrote it because it rhymes ;).
 
 KNOWN BUGS:
-    Chokes on fastest times names greater than 16 characters long, must have
-    something to do with GetDlgItemText.
-  
     No help file.
 
     Starting a new game causes the window to drop one pixel (Peter Hunnisett)

programs/winemine/main.c

diff --git a/programs/winemine/main.c b/programs/winemine/main.c
index 13311c7..a8ea08e 100644
--- a/programs/winemine/main.c
+++ b/programs/winemine/main.c
@@ -277,7 +277,7 @@
     DWORD size;
     DWORD type;
     HKEY hkey;
-    char data[16];
+    char data[MAX_PLAYER_NAME_SIZE+1];
     char key_name[8];
     unsigned i;
 
@@ -327,7 +327,7 @@
                 (LPDWORD) &size ) == ERROR_SUCCESS )
                     lstrcpynA( p_board->best_name[i], data, sizeof(p_board->best_name[i]) );
         else
-            LoadString( p_board->hInst, IDS_NOBODY, p_board->best_name[i], 16 );
+            LoadString( p_board->hInst, IDS_NOBODY, p_board->best_name[i], MAX_PLAYER_NAME_SIZE+1 );
     }
 
     for( i = 0; i < 3; i++ ) {
@@ -345,7 +345,7 @@
 {
     HKEY hkey;
     unsigned i;
-    char data[16];
+    char data[MAX_PLAYER_NAME_SIZE+1];
     char key_name[8];
 
     if( RegCreateKeyEx( HKEY_CURRENT_USER, registry_key,

programs/winemine/main.h

diff --git a/programs/winemine/main.h b/programs/winemine/main.h
index 16fcb2e..a813c95 100644
--- a/programs/winemine/main.h
+++ b/programs/winemine/main.h
@@ -45,6 +45,8 @@
 #define FACE_WIDTH       24
 #define FACE_HEIGHT      24
 
+#define MAX_PLAYER_NAME_SIZE 31
+
 typedef enum { SPRESS_BMP, COOL_BMP, DEAD_BMP, OOH_BMP, SMILE_BMP } FACE_BMP;
 
 typedef enum { WAITING, PLAYING, GAMEOVER, WON } GAME_STATUS;
@@ -84,7 +86,7 @@
     unsigned rows;
     unsigned cols;
     unsigned mines;
-    char best_name [3][16];
+    char best_name [3][MAX_PLAYER_NAME_SIZE+1];
     DWORD best_time [3];
     DIFFICULTY difficulty;