commit b58094f74c2d773f110443ba52b873d1d6a8c829
author Fabian Maurer <dark.shadow4@web.de> Tue Oct 03 17:28:08 2017 +0200
committer Alexandre Julliard <julliard@winehq.org> Tue Oct 03 19:58:16 2017 +0200
tree 0ffd3a6c6d8ecfd4bf51ef4feee6ada8e6e9c543
parent fe2d45094f8e9b05b9d1626f6639befc3fa7294d

winedump: Fix potential null-pointer dereference (cppcheck).

Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

tools/winedump/pdb.c

diff --git a/tools/winedump/pdb.c b/tools/winedump/pdb.c
index 6a6a9b4..6fd70ce 100644
--- a/tools/winedump/pdb.c
+++ b/tools/winedump/pdb.c
@@ -215,7 +215,8 @@
     stream_idx = get_stream_by_name(reader, "/names");
     if (stream_idx == -1) return NULL;
     ret = reader->read_file(reader, stream_idx);
-    if (ret && *(const DWORD*)ret == 0xeffeeffe) return ret;
+    if (!ret) return NULL;
+    if(*(const DWORD*)ret == 0xeffeeffe) return ret;
     printf("wrong header %x expecting 0xeffeeffe\n", *(const DWORD*)ret);
     free( ret );
     return NULL;