commit a3c6bc68c815ee4a3ac6f33d74ddf065a7dc0fe9
author Juan Lang <juan.lang@gmail.com> Thu Nov 19 10:49:31 2009 -0800
committer Alexandre Julliard <julliard@winehq.org> Fri Nov 20 11:14:52 2009 +0100
tree f00754375ee87fae9ca7d10cc1d012e02b83ffa8
parent 9e1d31e5e52449cf4dcf6409dc4e71cf8b2a4383

crypt32: Assume revocation server is offline if revocation status isn't known.

dlls/crypt32/chain.c

diff --git a/dlls/crypt32/chain.c b/dlls/crypt32/chain.c
index d320111..0f2b5dd 100644
--- a/dlls/crypt32/chain.c
+++ b/dlls/crypt32/chain.c
@@ -2426,7 +2426,11 @@
                 case CRYPT_E_NO_REVOCATION_CHECK:
                 case CRYPT_E_NO_REVOCATION_DLL:
                 case CRYPT_E_NOT_IN_REVOCATION_DATABASE:
-                    error = CERT_TRUST_REVOCATION_STATUS_UNKNOWN;
+                    /* If the revocation status is unknown, it's assumed to be
+                     * offline too.
+                     */
+                    error = CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
+                     CERT_TRUST_IS_OFFLINE_REVOCATION;
                     break;
                 case CRYPT_E_REVOCATION_OFFLINE:
                     error = CERT_TRUST_IS_OFFLINE_REVOCATION;

dlls/crypt32/tests/chain.c

diff --git a/dlls/crypt32/tests/chain.c b/dlls/crypt32/tests/chain.c
index f192d94..2b8d967 100644
--- a/dlls/crypt32/tests/chain.c
+++ b/dlls/crypt32/tests/chain.c
@@ -3688,7 +3688,6 @@
         /* The cert is rather old, so its revocation list can't be retrieved,
          * and its revocation status should be both offline and unknown.
          */
-        todo_wine
         ok((chain->TrustStatus.dwErrorStatus & revocationFlags) ==
          (CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
          CERT_TRUST_IS_OFFLINE_REVOCATION),
@@ -3709,7 +3708,6 @@
     if (ret)
     {
         /* Even with a CRL in the store, the revocation status doesn't change */
-        todo_wine
         ok((chain->TrustStatus.dwErrorStatus & revocationFlags) ==
          (CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
          CERT_TRUST_IS_OFFLINE_REVOCATION),
@@ -3744,7 +3742,6 @@
         /* The cert doesn't have a way to retrieve its CRL, so its revocation
          * status should be both offline and unknown.
          */
-        todo_wine
         ok((chain->TrustStatus.dwErrorStatus & revocationFlags) ==
          (CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
          CERT_TRUST_IS_OFFLINE_REVOCATION),
@@ -3765,7 +3762,6 @@
     if (ret)
     {
         /* Even with a CRL in the store, the revocation status doesn't change */
-        todo_wine
         ok((chain->TrustStatus.dwErrorStatus & revocationFlags) ==
          (CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
          CERT_TRUST_IS_OFFLINE_REVOCATION),
@@ -3795,7 +3791,6 @@
     if (ret)
     {
         /* Even with a CRL in the store, the revocation status doesn't change */
-        todo_wine
         ok((chain->TrustStatus.dwErrorStatus & revocationFlags) ==
          (CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
          CERT_TRUST_IS_OFFLINE_REVOCATION),
@@ -3824,7 +3819,6 @@
     if (ret)
     {
         /* Even with a CRL in the store, the revocation status doesn't change */
-        todo_wine
         ok((chain->TrustStatus.dwErrorStatus & revocationFlags) ==
          (CERT_TRUST_REVOCATION_STATUS_UNKNOWN |
          CERT_TRUST_IS_OFFLINE_REVOCATION),