commit a06c2570e5870d1c5538760442956fedab1594ea
author Andrew Eikum <andrew@brightnightgames.com> Tue Jul 07 22:30:29 2009 -0500
committer Alexandre Julliard <julliard@winehq.org> Wed Jul 08 20:35:09 2009 +0200
tree d30c24d9f0f6041956f0248c2bbce0a9da4265d3
parent 099f031051af2112b82a98c4aa3910fbd70a3542

gdiplus: Don't modify container list if container restoration fails.

dlls/gdiplus/graphics.c

diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c
index b81a984..12f1e26 100644
--- a/dlls/gdiplus/graphics.c
+++ b/dlls/gdiplus/graphics.c
@@ -3400,7 +3400,7 @@
     return NotImplemented;
 }
 
-GpStatus WINGDIPAPI GdipEndContainer(GpGraphics *graphics, GraphicsState state)
+GpStatus WINGDIPAPI GdipEndContainer(GpGraphics *graphics, GraphicsContainer state)
 {
     GpStatus sts;
     GraphicsContainerItem *container, *container2;
@@ -3419,6 +3419,10 @@
     if(&container->entry == &graphics->containers)
         return Ok;
 
+    sts = restore_container(graphics, container);
+    if(sts != Ok)
+        return sts;
+
     /* remove all of the containers on top of the found container */
     LIST_FOR_EACH_ENTRY_SAFE(container, container2, &graphics->containers, GraphicsContainerItem, entry){
         if(container->contid == state)
@@ -3428,10 +3432,9 @@
     }
 
     list_remove(&container->entry);
-    sts = restore_container(graphics, container);
     delete_container(container);
 
-    return sts;
+    return Ok;
 }
 
 GpStatus WINGDIPAPI GdipScaleWorldTransform(GpGraphics *graphics, REAL sx,