commit a018d8508f7f7a10ffc03819dc695fe4f77ca969
author Noomen Hamza <noomen@macadamian.com> Tue Sep 28 16:26:09 1999 +0000
committer Alexandre Julliard <julliard@winehq.org> Tue Sep 28 16:26:09 1999 +0000
tree 2c830937dbb7297bd4ed9a74a36ea0e47d8f2072
parent 13409b32cd1a064973a25277b6424882f940c5fa

Rewrite the ShowOwnedPopups function with a safety algorithm.

windows/win.c

diff --git a/windows/win.c b/windows/win.c
index 3e41d79..cc7fff6 100644
--- a/windows/win.c
+++ b/windows/win.c
@@ -2641,15 +2641,20 @@
  */
 BOOL WINAPI ShowOwnedPopups( HWND owner, BOOL fShow )
 {
-    WND *pWnd;
-    pWnd = WIN_LockWndPtr(pWndDesktop->child);
-    while (pWnd)
+    UINT totalChild=0, count=0;
+
+    WND **pWnd = WIN_BuildWinArray(WIN_GetDesktop(), 0, &totalChild);
+
+    if (!pWnd) return TRUE;
+
+    for (; count < totalChild; count++)
     {
-        if (pWnd->owner && (pWnd->owner->hwndSelf == owner) &&
-            (pWnd->dwStyle & WS_POPUP))
-            ShowWindow( pWnd->hwndSelf, fShow ? SW_SHOW : SW_HIDE );
-        WIN_UpdateWndPtr(&pWnd,pWnd->next);
+        if (pWnd[count]->owner && (pWnd[count]->owner->hwndSelf == owner) && (pWnd[count]->dwStyle & WS_POPUP))
+            SendMessageA(pWnd[count]->hwndSelf, WM_SHOWWINDOW, fShow ? SW_SHOW : SW_HIDE,IsIconic(owner) ? SW_PARENTOPENING : SW_PARENTCLOSING);
     }
+
+    WIN_ReleaseDesktop();    
+    WIN_ReleaseWinArray(pWnd);
     return TRUE;
 }