commit 9d4ae0eff9b5d283fe4b39d6f45f06e48e50e87d
author Rein Klazes <rklazes@casema.net> Mon Apr 02 19:13:24 2001 +0000
committer Alexandre Julliard <julliard@winehq.org> Mon Apr 02 19:13:24 2001 +0000
tree 29fbbe1ebb7fac25c1fa4bc60a2206f79e30edd6
parent 12a79232241a2c6e7348f4c3de5dd1ccfc218e25

Do not send the EN_CHANGE notification message until the selection
start and end values are filled in.

controls/edit.c

diff --git a/controls/edit.c b/controls/edit.c
index 8051e96..97e6318 100644
--- a/controls/edit.c
+++ b/controls/edit.c
@@ -3615,8 +3615,10 @@
 
 	EDIT_EM_SetSel(wnd, es, es->undo_position, es->undo_position + es->undo_insert_count, FALSE);
 	EDIT_EM_EmptyUndoBuffer(es);
-	EDIT_EM_ReplaceSel(wnd, es, TRUE, utext, TRUE);
+	EDIT_EM_ReplaceSel(wnd, es, TRUE, utext, FALSE);
 	EDIT_EM_SetSel(wnd, es, es->undo_position, es->undo_position + es->undo_insert_count, FALSE);
+        /* send the notification after the selection start and end are set */
+        EDIT_NOTIFY_PARENT(es, EN_CHANGE, "EN_CHANGE");
 	EDIT_EM_ScrollCaret(wnd, es);
 	HeapFree(GetProcessHeap(), 0, utext);
 
@@ -3824,13 +3826,15 @@
         EDIT_EM_EmptyUndoBuffer(es);
 
        if (name && *name) {
-	   EDIT_EM_ReplaceSel(wnd, es, FALSE, name, TRUE);
+	   EDIT_EM_ReplaceSel(wnd, es, FALSE, name, FALSE);
 	   /* if we insert text to the editline, the text scrolls out
             * of the window, as the caret is placed after the insert
             * pos normally; thus we reset es->selection... to 0 and
             * update caret
             */
 	   es->selection_start = es->selection_end = 0;
+           /* send the notification after the selection start and end are set */
+           EDIT_NOTIFY_PARENT(es, EN_CHANGE, "EN_CHANGE");
 	   EDIT_EM_ScrollCaret(wnd, es);
        }
        /* force scroll info update */
@@ -4666,23 +4670,23 @@
 	EDIT_EM_SetSel(wnd, es, 0, (UINT)-1, FALSE);
 	if (text) {
 		TRACE("%s\n", debugstr_w(text));
-		/* edit control doesn't send notification on WM_SETTEXT
-		 * if it is multiline, or it is part of combobox
-		 */
-		EDIT_EM_ReplaceSel(wnd, es, FALSE, text, !((es->style & ES_MULTILINE) || es->hwndListBox));
+		EDIT_EM_ReplaceSel(wnd, es, FALSE, text, FALSE);
 		if(!unicode)
 		    HeapFree(GetProcessHeap(), 0, text);
 	} else {
 		static const WCHAR empty_stringW[] = {0};
 		TRACE("<NULL>\n");
-		/* edit control doesn't send notification on WM_SETTEXT
-		 * if it is multiline, or it is part of combobox
-		 */
-		EDIT_EM_ReplaceSel(wnd, es, FALSE, empty_stringW, !((es->style & ES_MULTILINE) || es->hwndListBox));
+		EDIT_EM_ReplaceSel(wnd, es, FALSE, empty_stringW, FALSE);
 	}
 	es->x_offset = 0;
 	es->flags &= ~EF_MODIFIED;
 	EDIT_EM_SetSel(wnd, es, 0, 0, FALSE);
+        /* Send the notification after the selection start and end have been set
+         * edit control doesn't send notification on WM_SETTEXT
+         * if it is multiline, or it is part of combobox
+         */
+	if( !((es->style & ES_MULTILINE) || es->hwndListBox))
+	    EDIT_NOTIFY_PARENT(es, EN_CHANGE, "EN_CHANGE");
 	EDIT_EM_ScrollCaret(wnd, es);
 }