commit 98aacc7751df5c3c56684357cc8800dab35a1087
author Alexandre Julliard <julliard@winehq.org> Wed Mar 15 19:46:14 2000 +0000
committer Alexandre Julliard <julliard@winehq.org> Wed Mar 15 19:46:14 2000 +0000
tree 2dc629046016f007d7d23b0880048beadebadcb1
parent f2f1ff333e60595a899eb57f10bb70cbb91e163d

Avoid SIGSTOP/SIGCONT race when ptrace is disabled.

server/process.c

diff --git a/server/process.c b/server/process.c
index 297ef00..8073e55 100644
--- a/server/process.c
+++ b/server/process.c
@@ -462,8 +462,7 @@
         set_error( STATUS_ACCESS_DENIED );
         return;
     }
-    suspend_thread( thread, 0 );
-    if (thread->attached)
+    if (suspend_for_ptrace( thread ))
     {
         while (len > 0 && max)
         {
@@ -483,10 +482,9 @@
             }
             if (len && (read_thread_int( thread, addr + len - 1, &dummy ) == -1)) goto done;
         }
+    done:
+        resume_thread( thread );
     }
-    else set_error( STATUS_ACCESS_DENIED );
- done:
-    resume_thread( thread );
 }
 
 /* write data to a process memory space */
@@ -508,8 +506,7 @@
         set_error( STATUS_ACCESS_DENIED );
         return;
     }
-    suspend_thread( thread, 0 );
-    if (thread->attached)
+    if (suspend_for_ptrace( thread ))
     {
         /* first word is special */
         if (len > 1)
@@ -544,10 +541,9 @@
             }
             if (len && (write_thread_int( thread, addr + len - 1, 0, 0 ) == -1)) goto done;
         }
+    done:
+        resume_thread( thread );
     }
-    else set_error( STATUS_ACCESS_DENIED );
- done:
-    resume_thread( thread );
 }
 
 /* take a snapshot of currently running processes */