commit 98934f20d8149ad93355e86d8a5f0a96b57678e9
author Alexandre Julliard <julliard@winehq.org> Thu Jul 12 17:32:07 2007 +0200
committer Alexandre Julliard <julliard@winehq.org> Thu Jul 12 17:32:07 2007 +0200
tree 3773b327099ad0f0d6111ef26738e1a78a4ec33c
parent 4688389d74ec1a6c5750589ec27419c70b82f968

dnsapi: Fix some potential infinite loops because of an unsigned loop counter.

dlls/dnsapi/query.c

diff --git a/dlls/dnsapi/query.c b/dlls/dnsapi/query.c
index 9522929..608f496 100644
--- a/dlls/dnsapi/query.c
+++ b/dlls/dnsapi/query.c
@@ -418,8 +418,7 @@
             r->Data.TXT.pStringArray[i] = dns_str_from_rdata( pos );
             if (!r->Data.TXT.pStringArray[i])
             {
-                for (--i; i >= 0; i--)
-                    dns_free( r->Data.TXT.pStringArray[i] );
+                while (i > 0) dns_free( r->Data.TXT.pStringArray[--i] );
                 return ERROR_NOT_ENOUGH_MEMORY;
             }
             i++;

dlls/dnsapi/record.c

diff --git a/dlls/dnsapi/record.c b/dlls/dnsapi/record.c
index d8941fd..8680b31 100644
--- a/dlls/dnsapi/record.c
+++ b/dlls/dnsapi/record.c
@@ -443,8 +443,7 @@
 
             if (!dst->Data.TXT.pStringArray[i])
             {
-                for (--i; i >= 0; i--)
-                    dns_free( dst->Data.TXT.pStringArray[i] );
+                while (i > 0) dns_free( dst->Data.TXT.pStringArray[--i] );
                 goto error;
             }
         }