commit 83300893a2372b01c70b9034b28deda5f783602c
author Alistair Leslie-Hughes <leslie_alistair@hotmail.com> Mon Jan 14 21:13:01 2008 +1100
committer Alexandre Julliard <julliard@winehq.org> Mon Jan 14 15:53:05 2008 +0100
tree f46e0c45fcafbd700cbb4868510468a160f89d2d
parent b57a7e01d6fed42cf767881958c0832390d2da18

msxml3: Corrected getAttribute to return current value and assign output var.

dlls/msxml3/element.c

diff --git a/dlls/msxml3/element.c b/dlls/msxml3/element.c
index e7f03d6..814a987 100644
--- a/dlls/msxml3/element.c
+++ b/dlls/msxml3/element.c
@@ -459,15 +459,20 @@
     domelem *This = impl_from_IXMLDOMElement( iface );
     xmlNodePtr element;
     xmlChar *xml_name, *xml_value;
-    HRESULT hr = E_FAIL;
+    HRESULT hr = S_FALSE;
 
     TRACE("(%p)->(%s,%p)\n", This, debugstr_w(name), value);
 
+    if(!value || !name)
+        return E_INVALIDARG;
+
     element = get_element( This );
     if ( !element )
         return E_FAIL;
 
-    VariantInit(value);
+    V_BSTR(value) = NULL;
+    V_VT(value) = VT_NULL;
+
     xml_name = xmlChar_from_wchar( name );
     xml_value = xmlGetNsProp(element, xml_name, NULL);
     HeapFree(GetProcessHeap(), 0, xml_name);