commit 760f487f6cbda0dc9f15403c987cfc68ec9bc134
author Huw Davies <huw@codeweavers.com> Wed Jul 11 11:46:14 2012 +0100
committer Alexandre Julliard <julliard@winehq.org> Wed Jul 11 10:00:15 2012 -0500
tree efd6b971d56dd9ad57b9fd70518af28595ad12a7
parent 0821c8024bd04eebc1a5047ec62ce7cf76c552f3

ntdll: Increase the buffer size for processor features and add a check to catch future overflows.

dlls/ntdll/nt.c

diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c
index 6d6e0b0..4b3f83a 100644
--- a/dlls/ntdll/nt.c
+++ b/dlls/ntdll/nt.c
@@ -1217,7 +1217,7 @@
         unsigned long long longVal;
         int value;
         int cputype;
-        char buffer[256];
+        char buffer[1024];
 
         valSize = sizeof(int);
         if (sysctlbyname ("hw.optional.floatingpoint", &value, &valSize, NULL, 0) == 0)
@@ -1280,6 +1280,7 @@
                 if (sysctlbyname ("machdep.cpu.features", buffer, &valSize, NULL, 0) == 0)
                 {
                     cached_sci.Revision |= value;
+                    if (!valSize) FIXME("Buffer not large enough, please increase\n");
                     if (strstr(buffer, "CX8"))   user_shared_data->ProcessorFeatures[PF_COMPARE_EXCHANGE_DOUBLE] = TRUE;
                     if (strstr(buffer, "CX16"))  user_shared_data->ProcessorFeatures[PF_COMPARE_EXCHANGE128] = TRUE;
                     if (strstr(buffer, "MMX"))   user_shared_data->ProcessorFeatures[PF_MMX_INSTRUCTIONS_AVAILABLE] = TRUE;