commit 6076485fde9baf2e3bc109267e91761b14de9a90
author Dmitry Timoshkov <dmitry@codeweavers.com> Fri Jun 15 17:43:40 2007 +0900
committer Alexandre Julliard <julliard@winehq.org> Fri Jun 15 12:41:07 2007 +0200
tree 9eaf12335bb0dd8022d0075eb7391685fc92c425
parent 3c444ea350e0688247bd2056b3861dac4af08fbc

msi: Simplify the code.

dlls/msi/action.c

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 00ed572..d09ddd0 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -4587,30 +4587,20 @@
     static const WCHAR prefix[] = {'[','~',']',0};
 
     *flags = 0;
-    while (*cptr && (*cptr == '=' || *cptr == '+' ||
-           *cptr == '-' || *cptr == '!' || *cptr == '*'))
+    while (*cptr)
     {
-        switch (*cptr)
-        {
-        case '=':
+        if (*cptr == '=')
             *flags |= ENV_ACT_SETALWAYS;
-            break;
-        case '+':
+        else if (*cptr == '+')
             *flags |= ENV_ACT_SETABSENT;
-            break;
-        case '-':
+        else if (*cptr == '-')
             *flags |= ENV_ACT_REMOVE;
-            break;
-        case '!':
+        else if (*cptr == '!')
             *flags |= ENV_ACT_REMOVEMATCH;
-            break;
-        case '*':
+        else if (*cptr == '*')
             *flags |= ENV_MOD_MACHINE;
+        else
             break;
-        default:
-            ERR("Unknown Environment flag: %c\n", *cptr);
-            return ERROR_FUNCTION_FAILED;
-        }
 
         cptr++;
         (*name)++;