commit 596921da0cf3765940d5ce6e5993f1b91c9c2cce
author Alexandre Julliard <julliard@winehq.org> Sat Jun 24 20:53:47 2000 +0000
committer Alexandre Julliard <julliard@winehq.org> Sat Jun 24 20:53:47 2000 +0000
tree 843e4756365cb4754f7e0e97a531f8df3d6952bc
parent b4905d2241a35b40b75964a204534cbcedcdf0d5

Make sure the cmdline passed to CreateProcessA is writeable (thanks to
Peter Ganten <peter@ganten.org>).

loader/module.c

diff --git a/loader/module.c b/loader/module.c
index a55837a..d8bbe6c 100644
--- a/loader/module.c
+++ b/loader/module.c
@@ -723,13 +723,17 @@
     PROCESS_INFORMATION info;
     STARTUPINFOA startup;
     HINSTANCE hInstance;
+    char *cmdline;
 
     memset( &startup, 0, sizeof(startup) );
     startup.cb = sizeof(startup);
     startup.dwFlags = STARTF_USESHOWWINDOW;
     startup.wShowWindow = nCmdShow;
 
-    if (CreateProcessA( NULL, (LPSTR)lpCmdLine, NULL, NULL, FALSE,
+    /* cmdline needs to be writeable for CreateProcess */
+    if (!(cmdline = HEAP_strdupA( GetProcessHeap(), 0, lpCmdLine ))) return 0;
+
+    if (CreateProcessA( NULL, cmdline, NULL, NULL, FALSE,
                         0, NULL, NULL, &startup, &info ))
     {
         /* Give 30 seconds to the app to come up */
@@ -745,7 +749,7 @@
         FIXME("Strange error set by CreateProcess: %d\n", hInstance );
         hInstance = 11;
     }
-
+    HeapFree( GetProcessHeap(), 0, cmdline );
     return hInstance;
 }