commit 53d40899b1edaa5bc529f13d7609357dc4f25a61
author Susan Farley <sfarley@codeweavers.com> Wed Aug 23 19:12:36 2000 +0000
committer Alexandre Julliard <julliard@winehq.org> Wed Aug 23 19:12:36 2000 +0000
tree 50886d258183de4d8c4480c2faf9f4ab2319e3fe
parent 5ee28aebc815321190a189234904b0a7f318187e

Large caption icons should end in '...' when they are abbreviated.

dlls/comctl32/listview.c

diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index d2e8435..8e7fe56 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -164,6 +164,8 @@
 /* Padding behind the label */
 #define TRAILING_PADDING  5
 
+/* Border for the icon caption */
+#define CAPTION_BORDER  2
 /* 
  * macros
  */
@@ -2906,7 +2908,7 @@
   LISTVIEW_INFO *infoPtr = (LISTVIEW_INFO *)GetWindowLongA(hwnd, 0); 
   CHAR szDispText[DISP_TEXT_SIZE];
   INT nDrawPosX = rcItem.left;
-  INT nLabelWidth;
+  INT nLabelWidth, rcWidth;
   TEXTMETRICA tm;
   LVITEMA lvItem;
 
@@ -2961,13 +2963,40 @@
   if (infoPtr->hwndEdit && lvItem.state & LVIS_FOCUSED)
     return;
 
+  InflateRect(&rcItem, -(2*CAPTION_BORDER), 0);
   rcItem.top += infoPtr->iconSize.cy + ICON_BOTTOM_PADDING; 
   nLabelWidth = ListView_GetStringWidthA(hwnd, lvItem.pszText);
-  nDrawPosX = infoPtr->iconSpacing.cx - nLabelWidth;
+  GetTextMetricsA(hdc, &tm);
+
+  /* append an ellipse ('...') if the caption won't fit in the rect */
+  rcWidth = max(0, rcItem.right - rcItem.left);
+  if (nLabelWidth > rcWidth)
+  {
+      INT i, len, eos, nCharsFit;
+      /* give or take a couple, how many average sized chars would fit? */
+      nCharsFit = tm.tmAveCharWidth > 0 ? (rcWidth/tm.tmAveCharWidth)+2 : 0; 
+      /* place the ellipse accordingly, without overrunning the buffer */
+      len = strlen(szDispText);
+      eos = min((nCharsFit > 1 && nCharsFit < len) ? nCharsFit+3 : len+2,
+                sizeof(szDispText)-1);
+      
+      nLabelWidth = ListView_GetStringWidthA(hwnd, szDispText);
+      while ((nLabelWidth > rcWidth) && (eos > 3))
+      {
+	 for (i = 1; i < 4; i++)
+	    szDispText[eos-i] = '.'; 
+         /* shift the ellipse one char to the left for each iteration */
+         szDispText[eos--] = '\0'; 
+         nLabelWidth = ListView_GetStringWidthA(hwnd, szDispText);
+      }
+  }
+
+  InflateRect(&rcItem, 2*CAPTION_BORDER, 0);
+  nDrawPosX = infoPtr->iconSpacing.cx - 2*CAPTION_BORDER - nLabelWidth;
   if (nDrawPosX > 1)
   {
     rcItem.left += nDrawPosX / 2;
-    rcItem.right = rcItem.left + nLabelWidth;
+    rcItem.right = rcItem.left + nLabelWidth + 2*CAPTION_BORDER;
   }
   else
   {
@@ -2976,9 +3005,8 @@
   }
 
   /* draw label */  
-  GetTextMetricsA(hdc, &tm);
   rcItem.bottom = rcItem.top + tm.tmHeight + HEIGHT_PADDING; 
-  ExtTextOutA(hdc, rcItem.left, rcItem.top, ETO_OPAQUE | ETO_CLIPPED, 
+  ExtTextOutA(hdc, rcItem.left + CAPTION_BORDER, rcItem.top, ETO_OPAQUE | ETO_CLIPPED, 
               &rcItem, lvItem.pszText, lstrlenA(lvItem.pszText), NULL);