commit 46ec7ee183129cc1099a001febc5e77225ecacfb
author James Hawkins <truiken@gmail.com> Wed Oct 17 22:53:54 2007 -0500
committer Alexandre Julliard <julliard@winehq.org> Thu Oct 18 12:09:33 2007 +0200
tree 193d9ca02968da2323b1a348d9cc6999e31018bf
parent 1d0f9378bc855652bf45db0e29b07fa85724dbd1

msi: Return ERROR_FUNCTION_FAILED when inserting duplicate keys.

dlls/msi/table.c

diff --git a/dlls/msi/table.c b/dlls/msi/table.c
index c5850e3..692f4a5 100644
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -1490,7 +1490,7 @@
     /* check there's no duplicate keys */
     r = msi_table_find_row( tv, rec, &row );
     if (r == ERROR_SUCCESS)
-        return ERROR_INVALID_DATA;
+        return ERROR_FUNCTION_FAILED;
 
     return ERROR_SUCCESS;
 }

dlls/msi/tests/db.c

diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c
index 293cf0c..8887954 100644
--- a/dlls/msi/tests/db.c
+++ b/dlls/msi/tests/db.c
@@ -791,10 +791,8 @@
     ok(r == ERROR_SUCCESS, "MsiViewExecute failed\n");
 
     /* should fail ... */
-    todo_wine {
     r = MsiViewModify(hview, MSIMODIFY_INSERT_TEMPORARY, hrec );
     ok(r == ERROR_FUNCTION_FAILED, "MsiViewModify failed\n");
-    }
 
     r = MsiCloseHandle(hrec);
     ok(r == ERROR_SUCCESS, "failed to close record\n");