commit 3669b94160a94c2f266ab065a11579a42e31365e
author Ove Kaaven <ovek@arcticnet.no> Sun Nov 07 05:23:02 1999 +0000
committer Alexandre Julliard <julliard@winehq.org> Sun Nov 07 05:23:02 1999 +0000
tree ac922bdea1e4f2a718e54057c0e345450d530f75
parent 4a0a7df6a3110a29a4ee8b203e03d4b8e7dce8ba

Handle socket creation errors.

server/sock.c

diff --git a/server/sock.c b/server/sock.c
index f3aa7bb..fef1ae6 100644
--- a/server/sock.c
+++ b/server/sock.c
@@ -297,10 +297,21 @@
 static struct object *create_socket( int family, int type, int protocol )
 {
     struct sock *sock;
+    int sockfd;
 
-    if (!(sock = alloc_object( &sock_ops )))
+    sockfd = socket( family, type, protocol );
+    if (debug_level)
+        fprintf(stderr,"socket(%d,%d,%d)=%d\n",family,type,protocol,sockfd);
+    if (sockfd == -1) {
+        sock_set_error();
         return NULL;
-    sock->select.fd      = socket(family,type,protocol);
+    }
+    fcntl(sockfd, F_SETFL, O_NONBLOCK); /* make socket nonblocking */
+    if (!(sock = alloc_object( &sock_ops ))) {
+        close( sockfd );
+        return NULL;
+    }
+    sock->select.fd      = sockfd;
     sock->select.func    = sock_select_event;
     sock->select.private = sock;
     sock->state          = (type!=SOCK_STREAM) ? WS_FD_READ|WS_FD_WRITE : 0;
@@ -308,9 +319,6 @@
     sock->hmask          = 0;
     sock->pmask          = 0;
     sock->event          = NULL;
-    if (debug_level)
-        fprintf(stderr,"socket(%d,%d,%d)=%d\n",family,type,protocol,sock->select.fd);
-    fcntl(sock->select.fd, F_SETFL, O_NONBLOCK); /* make socket nonblocking */
     register_select_user( &sock->select );
     sock_reselect( sock );
     clear_error();
@@ -343,6 +351,7 @@
     }
     if (!(acceptsock = alloc_object( &sock_ops )))
     {
+        close( acceptfd );
         release_object( sock );
         return NULL;
     }