commit 309914f315ff95b8b5af36e0cb76a5513bedbc73
author Christian Inci <chris.pcguy.inci@gmail.com> Fri Jul 08 18:43:59 2011 +0200
committer Alexandre Julliard <julliard@winehq.org> Sat Jul 09 11:48:06 2011 +0200
tree 95ad136d6636da8b6650398c0d54510e44993247
parent 94e057dde557cc38fd7f73c4645bff3776b55783

setupapi: Fix return behaviour when the device key doesn't exist.

dlls/setupapi/devinst.c

diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
index 9176554..73a67ee 100644
--- a/dlls/setupapi/devinst.c
+++ b/dlls/setupapi/devinst.c
@@ -3728,8 +3728,13 @@
         WCHAR devId[10];
 
         sprintfW(devId, fmt, devInfo->devId);
-        RegOpenKeyExW(classKey, devId, 0, samDesired, &key);
+        l = RegOpenKeyExW(classKey, devId, 0, samDesired, &key);
         RegCloseKey(classKey);
+        if (l)
+        {
+            SetLastError(ERROR_KEY_DOES_NOT_EXIST);
+            return INVALID_HANDLE_VALUE;
+        }
     }
     return key;
 }

dlls/setupapi/tests/devinst.c

diff --git a/dlls/setupapi/tests/devinst.c b/dlls/setupapi/tests/devinst.c
index 3c01f32..df4a407 100644
--- a/dlls/setupapi/tests/devinst.c
+++ b/dlls/setupapi/tests/devinst.c
@@ -974,7 +974,6 @@
         key = pSetupDiOpenDevRegKey(set, &devInfo, DICS_FLAG_GLOBAL, 0,
          DIREG_DRV, 0);
         /* The software key isn't created by default */
-        todo_wine
         ok(key == INVALID_HANDLE_VALUE &&
          GetLastError() == ERROR_KEY_DOES_NOT_EXIST,
          "Expected ERROR_KEY_DOES_NOT_EXIST, got %08x\n", GetLastError());