commit 28cbea801cdeaef2952bef5c346cd1085ecf7585
author Bill Medland <Bill.Medland@accpac.com> Sat Apr 20 20:53:59 2002 +0000
committer Alexandre Julliard <julliard@winehq.org> Sat Apr 20 20:53:59 2002 +0000
tree edf6ac5e9ed81f70d673c738f7eafba4b6d1d231
parent c31086870f3bf400db3ac4ddcca600b5fd62aaad

Correct handling of zero-padded negative numbers; transfer the sign
BEFORE adding the zeroes.

dlls/user/wsprintf.c

diff --git a/dlls/user/wsprintf.c b/dlls/user/wsprintf.c
index 7c33a0a..78182ad 100644
--- a/dlls/user/wsprintf.c
+++ b/dlls/user/wsprintf.c
@@ -277,7 +277,7 @@
 {
     WPRINTF_FORMAT format;
     LPSTR p = buffer;
-    UINT i, len;
+    UINT i, len, sign;
     CHAR number[20];
     WPRINTF_DATA cur_arg;
     SEGPTR seg_str;
@@ -318,6 +318,7 @@
             continue;
         }
         len = WPRINTF_GetLen( &format, &cur_arg, number, maxlen - 1 );
+        sign = 0;
         if (!(format.flags & WPRINTF_LEFTALIGN))
             for (i = format.precision; i < format.width; i++, maxlen--)
                 *p++ = ' ';
@@ -346,9 +347,16 @@
             }
             /* fall through */
         case WPR_SIGNED:
+            /* Transfer the sign now, just in case it will be zero-padded*/
+            if (number[0] == '-')
+            {
+                *p++ = '-';
+                sign = 1;
+            }
+            /* fall through */
         case WPR_UNSIGNED:
             for (i = len; i < format.precision; i++, maxlen--) *p++ = '0';
-            if (len) memcpy( p, number, len );
+            if (len > sign) memcpy( p, number + sign, len - sign );
             p += len;
             break;
         case WPR_UNKNOWN:
@@ -371,7 +379,7 @@
 {
     WPRINTF_FORMAT format;
     LPSTR p = buffer;
-    UINT i, len;
+    UINT i, len, sign;
     CHAR number[20];
     WPRINTF_DATA argData;
 
@@ -409,6 +417,7 @@
         }
 
         len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1 );
+        sign = 0;
         if (!(format.flags & WPRINTF_LEFTALIGN))
             for (i = format.precision; i < format.width; i++, maxlen--)
                 *p++ = ' ';
@@ -440,10 +449,17 @@
             }
             /* fall through */
         case WPR_SIGNED:
+            /* Transfer the sign now, just in case it will be zero-padded*/
+            if (number[0] == '-')
+            {
+                *p++ = '-';
+                sign = 1;
+            }
+            /* fall through */
         case WPR_UNSIGNED:
             for (i = len; i < format.precision; i++, maxlen--) *p++ = '0';
-            memcpy( p, number, len );
-            p += len;
+            memcpy( p, number + sign, len - sign  );
+            p += len - sign;
             break;
         case WPR_UNKNOWN:
             continue;
@@ -466,7 +482,7 @@
 {
     WPRINTF_FORMAT format;
     LPWSTR p = buffer;
-    UINT i, len;
+    UINT i, len, sign;
     CHAR number[20];
     WPRINTF_DATA argData;
 
@@ -504,6 +520,7 @@
         }
 
         len = WPRINTF_GetLen( &format, &argData, number, maxlen - 1 );
+        sign = 0;
         if (!(format.flags & WPRINTF_LEFTALIGN))
             for (i = format.precision; i < format.width; i++, maxlen--)
                 *p++ = ' ';
@@ -535,9 +552,16 @@
             }
             /* fall through */
         case WPR_SIGNED:
+            /* Transfer the sign now, just in case it will be zero-padded*/
+            if (number[0] == '-')
+            {
+                *p++ = '-';
+                sign = 1;
+            }
+            /* fall through */
         case WPR_UNSIGNED:
             for (i = len; i < format.precision; i++, maxlen--) *p++ = '0';
-            for (i = 0; i < len; i++) *p++ = (WCHAR)number[i];
+            for (i = sign; i < len; i++) *p++ = (WCHAR)number[i];
             break;
         case WPR_UNKNOWN:
             continue;