commit 1f48c89e04ed9ce63ddbcd95cf8a6b71233e1923
author Dmitry Timoshkov <dmitry@baikal.ru> Fri Jun 08 14:08:28 2012 +0900
committer Alexandre Julliard <julliard@winehq.org> Fri Jun 08 19:35:19 2012 +0200
tree 12a08dc7bdf80e05ec971cecbd56ec099ef69bcf
parent 562b277bb313f05a1ab4cd15381eed5ba697e389

windowscodecs: Protect from invalid input some metadata handler methods.

dlls/windowscodecs/metadatahandler.c

diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c
index afcff21..013fe04 100644
--- a/dlls/windowscodecs/metadatahandler.c
+++ b/dlls/windowscodecs/metadatahandler.c
@@ -133,6 +133,8 @@
 static HRESULT WINAPI MetadataHandler_GetMetadataFormat(IWICMetadataWriter *iface,
     GUID *pguidMetadataFormat)
 {
+    if (!pguidMetadataFormat) return E_INVALIDARG;
+
     FIXME("(%p,%s): stub\n", iface, debugstr_guid(pguidMetadataFormat));
     return E_NOTIMPL;
 }
@@ -147,6 +149,8 @@
 static HRESULT WINAPI MetadataHandler_GetCount(IWICMetadataWriter *iface,
     UINT *pcCount)
 {
+    if (!pcCount) return E_INVALIDARG;
+
     FIXME("(%p,%p): stub\n", iface, pcCount);
     return E_NOTIMPL;
 }
@@ -514,6 +518,8 @@
 {
     MetadataHandlerEnum *This;
 
+    if (!ppIEnumMetadataItem) return E_INVALIDARG;
+
     *ppIEnumMetadataItem = NULL;
 
     This = HeapAlloc(GetProcessHeap(), 0, sizeof(MetadataHandlerEnum));