commit 0f5d6827db681b8ff23b8d60c3b040b3c26ece75
author Michael Stefaniuc <mstefani@redhat.de> Fri Aug 01 21:50:51 2008 +0200
committer Alexandre Julliard <julliard@winehq.org> Mon Aug 04 13:03:42 2008 +0200
tree 7ce37735bdeebff4478954e4040e519bfac72578
parent 5d4d5b16fd2ca99648e6755d09fe17298e952620

msxml3: Remove redundant NULL checks before HeapFree and fix a memleak (Smatch).

dlls/msxml3/saxreader.c

diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c
index 0b44a6e..4bba5e6 100644
--- a/dlls/msxml3/saxreader.c
+++ b/dlls/msxml3/saxreader.c
@@ -806,16 +806,12 @@
             || !attributes->szURI || !attributes->szValue
             || !attributes->szQName)
     {
-        if(attributes->szLocalname)
-            HeapFree(GetProcessHeap(), 0, attributes->szLocalname);
-        if(attributes->szPrefix)
-            HeapFree(GetProcessHeap(), 0, attributes->szPrefix);
-        if(attributes->szURI)
-            HeapFree(GetProcessHeap(), 0, attributes->szURI);
-        if(attributes->szValue)
-            HeapFree(GetProcessHeap(), 0, attributes->szValue);
-        if(attributes->szQName)
-            HeapFree(GetProcessHeap(), 0, attributes->szQName);
+        HeapFree(GetProcessHeap(), 0, attributes->szLocalname);
+        HeapFree(GetProcessHeap(), 0, attributes->szPrefix);
+        HeapFree(GetProcessHeap(), 0, attributes->szURI);
+        HeapFree(GetProcessHeap(), 0, attributes->szValue);
+        HeapFree(GetProcessHeap(), 0, attributes->szQName);
+        HeapFree(GetProcessHeap(), 0, attributes);
         return E_FAIL;
     }