commit 0ad6af9caa508a44fce9e0243054ea41956dac5a
author Józef Kucia <joseph.kucia@gmail.com> Tue Jul 03 16:06:43 2012 +0200
committer Alexandre Julliard <julliard@winehq.org> Mon Jul 09 15:43:42 2012 -0400
tree b49fc47890d648b27f90bf91178fababf3351eac
parent 563355d651e20a44800abef307746a3af4a179bb

d3dx9: Validate the size of a volume texture in D3DXGetImageInfoFromFile.

dlls/d3dx9_36/surface.c

diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c
index 845a1f7..6d2e778 100644
--- a/dlls/d3dx9_36/surface.c
+++ b/dlls/d3dx9_36/surface.c
@@ -317,8 +317,8 @@
 static HRESULT get_image_info_from_dds(const void *buffer, UINT length, D3DXIMAGE_INFO *info)
 {
    UINT i;
-   UINT faces = 0;
-   UINT width, height;
+   UINT faces = 1;
+   UINT width, height, depth;
    const struct dds_header *header = buffer;
    UINT expected_length = 0;
 
@@ -347,6 +347,7 @@
    else if (header->caps2 & DDS_CAPS2_CUBEMAP)
    {
        DWORD face;
+       faces = 0;
        for (face = DDS_CAPS2_CUBEMAP_POSITIVEX; face <= DDS_CAPS2_CUBEMAP_NEGATIVEZ; face <<= 1)
        {
            if (header->caps2 & face)
@@ -356,20 +357,22 @@
    }
    else
    {
-       faces = 1;
        info->ResourceType = D3DRTYPE_TEXTURE;
    }
 
    /* calculate the expected length */
    width = info->Width;
    height = info->Height;
+   depth = info->Depth;
    for (i = 0; i < info->MipLevels; i++)
    {
        UINT pitch, size = 0;
        calculate_dds_surface_size(info, width, height, &pitch, &size);
+       size *= depth;
        expected_length += size;
        width = max(1, width / 2);
        height = max(1, height / 2);
+       depth = max(1, depth / 2);
    }
 
    expected_length *= faces;

dlls/d3dx9_36/tests/surface.c

diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c
index 84b1c56..5a01200 100644
--- a/dlls/d3dx9_36/tests/surface.c
+++ b/dlls/d3dx9_36/tests/surface.c
@@ -544,7 +544,7 @@
     ok(hr == D3DXERR_INVALIDDATA, "D3DXGetImageInfoFromFileInMemory returned %#x, expected %#x\n", hr, D3DXERR_INVALIDDATA);
 
     hr = D3DXGetImageInfoFromFileInMemory(dds_volume_map, sizeof(dds_volume_map) - 1, &info);
-    todo_wine ok(hr == D3DXERR_INVALIDDATA, "D3DXGetImageInfoFromFileInMemory returned %#x, expected %#x\n", hr, D3DXERR_INVALIDDATA);
+    ok(hr == D3DXERR_INVALIDDATA, "D3DXGetImageInfoFromFileInMemory returned %#x, expected %#x\n", hr, D3DXERR_INVALIDDATA);
 
 
     /* cleanup */