commit 0876f7664a5b3e6bb8f8165d827e2401096bb6cd
author Rob Shearman <rob@codeweavers.com> Tue Jun 26 22:24:05 2007 +0100
committer Alexandre Julliard <julliard@winehq.org> Wed Jun 27 12:32:23 2007 +0200
tree 9296a98dfacc2d4a235db3515ad4b764908267e3
parent 023383afd3fa7f9f0a963a21425bc4563e4bed74

msi: Fix loading string tables for databases that use 3-byte string references and that have a non-zero codepage (i.e. != CP_ACP).

dlls/msi/string.c

diff --git a/dlls/msi/string.c b/dlls/msi/string.c
index 932b624..9008249 100644
--- a/dlls/msi/string.c
+++ b/dlls/msi/string.c
@@ -81,6 +81,12 @@
     string_table *st;
     int i;
 
+    if (codepage != CP_ACP && !IsValidCodePage(codepage))
+    {
+        ERR("invalid codepage %d\n", codepage);
+        return NULL;
+    }
+
     st = msi_alloc( sizeof (string_table) );
     if( !st )
         return NULL;    
@@ -269,7 +275,6 @@
     str = msi_alloc( (len+1)*sizeof(WCHAR) );
     if( !str )
         return -1;
-    TRACE("%d\n",__LINE__);
     memcpy( str, data, len*sizeof(WCHAR) );
     str[len] = 0;
 
@@ -516,8 +521,6 @@
     UINT r, datasize = 0, poolsize = 0, codepage;
     DWORD i, count, offset, len, n, refs;
 
-    static const USHORT large_str_sig[] = { 0x0000, 0x8000 };
-
     r = read_stream_data( stg, szStringPool, &pool, &poolsize );
     if( r != ERROR_SUCCESS)
         goto end;
@@ -525,18 +528,19 @@
     if( r != ERROR_SUCCESS)
         goto end;
 
-    if ( !memcmp(pool, large_str_sig, sizeof(large_str_sig)) )
+    if ( (poolsize > 4) && (pool[1] & 0x8000) )
         *bytes_per_strref = LONG_STR_BYTES;
     else
         *bytes_per_strref = sizeof(USHORT);
 
-    /* FIXME: don't know where the codepage is in large str tables */
     count = poolsize/4;
-    if( poolsize > 4 && *bytes_per_strref != LONG_STR_BYTES )
-        codepage = pool[0] | ( pool[1] << 16 );
+    if( poolsize > 4 )
+        codepage = pool[0] | ( (pool[1] & ~0x8000) << 16 );
     else
         codepage = CP_ACP;
     st = init_stringtable( count, codepage );
+    if (!st)
+        goto end;
 
     offset = 0;
     n = 1;