commit 052d955567864a7e0c9c51d726abb6ff6ebb0b95
author Henri Verbeet <hverbeet@codeweavers.com> Thu Oct 29 10:37:13 2009 +0100
committer Alexandre Julliard <julliard@winehq.org> Thu Oct 29 13:09:45 2009 +0100
tree 8b434fdee61fced8772fc873bbc5362bbfc90a49
parent be8026adf648305a958eb55c8647d3a6a2302f07

wined3d: Don't depend on uninitialized data in the CreateSurface() thunks (Valgrind).

Perhaps IDirectDraw7_CreateSurface() should also always set "pSurface7" to
NULL on failure, but at least for our internal functions that's a silly thing
to rely on.

dlls/ddraw/ddraw_thunks.c

diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c
index 8c79cbf..278d720 100644
--- a/dlls/ddraw/ddraw_thunks.c
+++ b/dlls/ddraw/ddraw_thunks.c
@@ -347,19 +347,17 @@
      * since the data layout is the same */
     hr = IDirectDraw7_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw1(This),
             (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter);
-
-    /* This coercion is safe, since the IDirectDrawSurface3 vtable has the
-     * IDirectDrawSurface vtable layout at the beginning  */
-    *ppSurface = pSurface7 ?
-            (IDirectDrawSurface *)&((IDirectDrawSurfaceImpl *)pSurface7)->IDirectDrawSurface3_vtbl : NULL;
+    if (FAILED(hr))
+    {
+        *ppSurface = NULL;
+        return hr;
+    }
 
     impl = (IDirectDrawSurfaceImpl *)pSurface7;
-    if(SUCCEEDED(hr) && impl)
-    {
-        set_surf_version(impl, 1);
-        IDirectDraw7_Release((IDirectDraw7 *)ddraw_from_ddraw1(This));
-        impl->ifaceToRelease = NULL;
-    }
+    *ppSurface = (IDirectDrawSurface *)&impl->IDirectDrawSurface3_vtbl;
+    set_surf_version(impl, 1);
+    IDirectDraw7_Release((IDirectDraw7 *)ddraw_from_ddraw1(This));
+    impl->ifaceToRelease = NULL;
 
     return hr;
 }
@@ -375,19 +373,17 @@
 
     hr = IDirectDraw7_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw2(This),
             (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter);
-
-    /* This coercion is safe, since the IDirectDrawSurface3 vtable has the
-     * IDirectDrawSurface vtable layout at the beginning  */
-    *ppSurface = pSurface7 ?
-            (IDirectDrawSurface *)&((IDirectDrawSurfaceImpl *)pSurface7)->IDirectDrawSurface3_vtbl : NULL;
+    if (FAILED(hr))
+    {
+        *ppSurface = NULL;
+        return hr;
+    }
 
     impl = (IDirectDrawSurfaceImpl *)pSurface7;
-    if(SUCCEEDED(hr) && impl)
-    {
-        set_surf_version(impl, 2);
-        IDirectDraw7_Release((IDirectDraw7 *)ddraw_from_ddraw2(This));
-        impl->ifaceToRelease = NULL;
-    }
+    *ppSurface = (IDirectDrawSurface *)&impl->IDirectDrawSurface3_vtbl;
+    set_surf_version(impl, 2);
+    IDirectDraw7_Release((IDirectDraw7 *)ddraw_from_ddraw2(This));
+    impl->ifaceToRelease = NULL;
 
     return hr;
 }
@@ -403,20 +399,18 @@
 
     hr = IDirectDraw7_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw3(This),
             (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter);
-
-    /* This coercion is safe, since the IDirectDrawSurface3 vtable has the
-     * IDirectDrawSurface vtable layout at the beginning  */
-    *ppSurface = pSurface7 ?
-            (IDirectDrawSurface *)&((IDirectDrawSurfaceImpl *)pSurface7)->IDirectDrawSurface3_vtbl : NULL;
+    if (FAILED(hr))
+    {
+        *ppSurface = NULL;
+        return hr;
+    }
 
     impl = (IDirectDrawSurfaceImpl *)pSurface7;
-    if(SUCCEEDED(hr) && impl)
-    {
-        set_surf_version(impl, 3);
-        IDirectDraw7_Release((IDirectDraw7 *)ddraw_from_ddraw3(This));
-        IDirectDraw3_AddRef(This);
-        impl->ifaceToRelease = (IUnknown *) This;
-    }
+    *ppSurface = (IDirectDrawSurface *)&impl->IDirectDrawSurface3_vtbl;
+    set_surf_version(impl, 3);
+    IDirectDraw7_Release((IDirectDraw7 *)ddraw_from_ddraw3(This));
+    IDirectDraw3_AddRef(This);
+    impl->ifaceToRelease = (IUnknown *) This;
 
     return hr;
 }