commit 01ecb577472e2bf24c9e9de8fdcb17fe30276dcc
author Alexandre Julliard <julliard@winehq.org> Mon Jun 10 23:02:19 2002 +0000
committer Alexandre Julliard <julliard@winehq.org> Mon Jun 10 23:02:19 2002 +0000
tree 673112ab5d5cacd10963e9679347b093eeb6ceac
parent 61fc6f8cd3b5bfb9221b39bb22bfdc88ce2e4996

Authors: David Hammerton <david@transgaming.com>, Peter Hunnisett <peter@transgaming.com>
- Fix TranslateMessage return code.
- Make GetKeyState work properly for apps that test 0x80 instead of
  0x8000.

windows/message.c

diff --git a/windows/message.c b/windows/message.c
index 856bbb1..dc8b530 100644
--- a/windows/message.c
+++ b/windows/message.c
@@ -633,8 +633,10 @@
     INT retval;
 
     if (vkey >= 'a' && vkey <= 'z') vkey += 'A' - 'a';
-    retval = ((WORD)(QueueKeyStateTable[vkey] & 0x80) << 8 ) | (QueueKeyStateTable[vkey] & 0x01);
-    /* TRACE(key, "(0x%x) -> %x\n", vkey, retval); */
+    retval = ((WORD)(QueueKeyStateTable[vkey] & 0x80) << 8 ) |
+              (QueueKeyStateTable[vkey] & 0x80) |
+              (QueueKeyStateTable[vkey] & 0x01);
+    TRACE("key (0x%x) -> %x\n", vkey, retval);
     return retval;
 }
 
@@ -938,18 +940,28 @@
  * ditto replacing WM_* with WM_SYS*
  * This produces WM_CHAR messages only for keys mapped to ASCII characters
  * by the keyboard driver.
+ *
+ * If the message is WM_KEYDOWN, WM_KEYUP, WM_SYSKEYDOWN, or WM_SYSKEYUP, the
+ * return value is nonzero, regardless of the translation.
+ *
  */
 BOOL WINAPI TranslateMessage( const MSG *msg )
 {
     static int dead_char;
     UINT message;
     WCHAR wp[2];
+    BOOL rc = FALSE;
 
     if (msg->message >= WM_KEYFIRST && msg->message <= WM_KEYLAST)
+    {
         TRACE_(key)("(%s, %04X, %08lX)\n",
                     SPY_GetMsgName(msg->message, msg->hwnd), msg->wParam, msg->lParam );
 
-    if ((msg->message != WM_KEYDOWN) && (msg->message != WM_SYSKEYDOWN)) return FALSE;
+        /* Return code must be TRUE no matter what! */
+        rc = TRUE;
+    }
+
+    if ((msg->message != WM_KEYDOWN) && (msg->message != WM_SYSKEYDOWN)) return rc;
 
     TRACE_(key)("Translating key %s (%04x), scancode %02x\n",
                  SPY_GetVKeyName(msg->wParam), msg->wParam, LOBYTE(HIWORD(msg->lParam)));
@@ -983,7 +995,7 @@
         }
         TRACE_(key)("1 -> PostMessage(%s)\n", SPY_GetMsgName(message, msg->hwnd));
         PostMessageW( msg->hwnd, message, wp[0], msg->lParam );
-        return TRUE;
+        break;
 
     case -1:
         message = (msg->message == WM_KEYDOWN) ? WM_DEADCHAR : WM_SYSDEADCHAR;
@@ -992,7 +1004,7 @@
         PostMessageW( msg->hwnd, message, wp[0], msg->lParam );
         return TRUE;
     }
-    return FALSE;
+    return rc;
 }